From 7e7f96b0b67baf96ff04a6a338461664d7f46f8d Mon Sep 17 00:00:00 2001 From: Andrea Dell'Amico Date: Wed, 25 Feb 2026 18:41:26 +0100 Subject: [PATCH] Fix the syntax of some tasks. --- tasks/ganesha-nfs.yml | 16 ++++++---------- tasks/nfs-kernel-server.yml | 18 +++++++----------- 2 files changed, 13 insertions(+), 21 deletions(-) diff --git a/tasks/ganesha-nfs.yml b/tasks/ganesha-nfs.yml index 408851a..441cbb7 100644 --- a/tasks/ganesha-nfs.yml +++ b/tasks/ganesha-nfs.yml @@ -1,5 +1,6 @@ --- - name: ganesha-nfs | Create the export directory trees + tags: [san, nfs, storage, ganesha, ganesha_export] block: - name: ganesha-nfs | Create the directory of the NFS exports ansible.builtin.file: @@ -10,9 +11,9 @@ mode: "0755" loop: "{{ nfs_server_ganesha_exports }}" - tags: [san, nfs, storage, ganesha, ganesha_export] - - name: ganesha-nfs | Repositories and packages on EL + when: ansible_distribution_file_variety == "RedHat" + tags: [san, nfs, storage, ganesha, ganesha_pkg] block: - name: ganesha-nfs | Install storage SIG repositories ansible.builtin.yum: @@ -41,10 +42,9 @@ when: ganesha_selinux_policy is changed # noqa: no-handler changed_when: true - when: ansible_distribution_file_variety == "RedHat" - tags: [san, nfs, storage, ganesha, ganesha_pkg] - - name: ganesha-nfs | Repositories and packages on Ubuntu/Debian + when: ansible_distribution_file_variety == "Debian" + tags: [san, nfs, storage, ganesha, ganesha_pkg] block: - name: ganesha-nfs | Install the nfs ganesha packages on deb systems ansible.builtin.apt: @@ -57,10 +57,8 @@ pkg: nfs-kernel-server state: absent - when: ansible_distribution_file_variety == "Debian" - tags: [san, nfs, storage, ganesha, ganesha_pkg] - - name: ganesha-nfs | Install and configure ganesha exports using the VFS backend + tags: [san, nfs, storage, ganesha, ganesha_conf] block: - name: ganesha-nfs | Install the ganesha configuration files ansible.builtin.template: @@ -100,5 +98,3 @@ name: nfs-ganesha state: reloaded when: ganesha_conf_files is changed # noqa: no-handler - - tags: [san, nfs, storage, ganesha, ganesha_conf] diff --git a/tasks/nfs-kernel-server.yml b/tasks/nfs-kernel-server.yml index 20d9f48..9771087 100644 --- a/tasks/nfs-kernel-server.yml +++ b/tasks/nfs-kernel-server.yml @@ -1,5 +1,6 @@ --- - name: nfs-kernel-server | Create the export directory trees + tags: [san, nfs, storage, kernel_nfs] block: - name: nfs-kernel-server | Create the directory of the NFS exports ansible.builtin.file: @@ -10,9 +11,9 @@ mode: "0755" loop: "{{ nfs_server_exports }}" - tags: [san, nfs, storage, kernel_nfs] - - name: nfs-kernel-server | Repositories and packages on EL + when: ansible_distribution_file_variety == "RedHat" + tags: [san, nfs, storage, kernel_nfs] block: - name: nfs-kernel-server | Install the NFS packages on EL ansible.builtin.yum: @@ -24,10 +25,9 @@ name: nfs-ganesha state: absent - when: ansible_distribution_file_variety == "RedHat" - tags: [san, nfs, storage, kernel_nfs] - - name: nfs-kernel-server | Repositories and packages on Ubuntu/Debian + when: ansible_distribution_file_variety == "Debian" + tags: [san, nfs, storage, kernel_nfs] block: - name: nfs-kernel-server | Install the nfs packages on deb systems ansible.builtin.apt: @@ -40,10 +40,8 @@ pkg: nfs-ganesha state: absent - when: ansible_distribution_file_variety == "Debian" - tags: [san, nfs, storage, kernel_nfs] - - name: nfs-kernel-server | Manage the NFS exports + tags: [san, nfs, storage, kernel_nfs, kernel_nfs_conf] block: - name: nfs-kernel-server | Create the NFS exports folder ansible.builtin.file: @@ -78,8 +76,6 @@ when: ansible_distribution_file_variety == "Debian" - name: nfs-kernel-server | Refresh the exports - ansible.builtin.shell: exportfs -r + ansible.builtin.command: exportfs -r when: update_exportfs is changed # noqa: no-handler changed_when: false - - tags: [san, nfs, storage, kernel_nfs, kernel_nfs_conf]